Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Foreman >= 3.9 #67

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

laugmanuel
Copy link
Member

  • migrate to settings DSL
  • drop old Foreman version support
  • switch to upstream CI
  • switch to upstream rubocop
  • add access permission test

@laugmanuel laugmanuel force-pushed the feat/support-new-foreman-versions branch 17 times, most recently from d899df5 to 179477f Compare May 8, 2024 12:13
@laugmanuel
Copy link
Member Author

@ekohl do you have an idea why the test:<plugin> test seems to be flaky? (see attempts in https://github.com/dm-drogeriemarkt/foreman_dlm/actions/runs/9001612772?pr=67 ). Re-running the tests without any change fixes the problem.

Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't think I've seen that flakiness before.

Rakefile Outdated Show resolved Hide resolved
foreman_dlm.gemspec Show resolved Hide resolved
lib/tasks/foreman_dlm_tasks.rake Outdated Show resolved Hide resolved
locale/gemspec.rb Outdated Show resolved Hide resolved
.tool-versions Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
@laugmanuel laugmanuel force-pushed the feat/support-new-foreman-versions branch 2 times, most recently from 163fbc2 to 6498b8d Compare May 8, 2024 13:39
@laugmanuel
Copy link
Member Author

Looks like the same problem again, bit I don't see any error. This plugin is the only one with acceptance tests using Capybara. Maybe we hit a caching or concurrency problem in Github actions?

@ekohl
Copy link
Contributor

ekohl commented May 8, 2024

AFAIK the test order is randomized. If you pass seed 3970 then perhaps you can reproduce it locally?

@laugmanuel laugmanuel force-pushed the feat/support-new-foreman-versions branch 3 times, most recently from e769d1f to d5bc436 Compare May 13, 2024 09:39
@laugmanuel
Copy link
Member Author

AFAIK the test order is randomized. If you pass seed 3970 then perhaps you can reproduce it locally?

Running the tests with DEBUG_JS_TEST=1 shows more information and reveals:

[MinitestRetry] retry 'test_0001_the index page works' count: 1,  msg: Selenium::WebDriver::Error::SessionNotCreatedError: session not created: Chrome failed to start: exited normally.
  (session not created: DevToolsActivePort file doesn't exist)
  (The process started from chrome location /opt/google/chrome/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
    test/integration_test_helper.rb:302:in `login_admin'
    test/test_helper.rb:84:in `before_setup'
    test/integration_test_helper.rb:331:in `before_setup'

I found a similar issue here: SeleniumHQ/selenium#12841

@laugmanuel laugmanuel force-pushed the feat/support-new-foreman-versions branch 2 times, most recently from 56fff33 to da2d4ad Compare May 13, 2024 10:50
@laugmanuel laugmanuel force-pushed the feat/support-new-foreman-versions branch 4 times, most recently from 8c934cc to ef34435 Compare May 13, 2024 12:46
- migrate to settings DSL
- drop old Foreman version support
- switch to upstream CI
- switch to upstream rubocop
- add access permission test
Copy link

@ochnerd ochnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me!

@laugmanuel laugmanuel merged commit 28db4f7 into master May 14, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants