-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Foreman >= 3.9 #67
Conversation
laugmanuel
commented
May 7, 2024
- migrate to settings DSL
- drop old Foreman version support
- switch to upstream CI
- switch to upstream rubocop
- add access permission test
d899df5
to
179477f
Compare
@ekohl do you have an idea why the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don't think I've seen that flakiness before.
163fbc2
to
6498b8d
Compare
Looks like the same problem again, bit I don't see any error. This plugin is the only one with acceptance tests using Capybara. Maybe we hit a caching or concurrency problem in Github actions? |
AFAIK the test order is randomized. If you pass seed |
e769d1f
to
d5bc436
Compare
Running the tests with [MinitestRetry] retry 'test_0001_the index page works' count: 1, msg: Selenium::WebDriver::Error::SessionNotCreatedError: session not created: Chrome failed to start: exited normally.
(session not created: DevToolsActivePort file doesn't exist)
(The process started from chrome location /opt/google/chrome/chrome is no longer running, so ChromeDriver is assuming that Chrome has crashed.)
test/integration_test_helper.rb:302:in `login_admin'
test/test_helper.rb:84:in `before_setup'
test/integration_test_helper.rb:331:in `before_setup' I found a similar issue here: SeleniumHQ/selenium#12841 |
56fff33
to
da2d4ad
Compare
8c934cc
to
ef34435
Compare
- migrate to settings DSL - drop old Foreman version support - switch to upstream CI - switch to upstream rubocop - add access permission test
ef34435
to
1e45473
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine for me!